fix(base component): Don't remove non-elements

kantord · Mar 9, 2018 · fde8467 · fde8467
1 parent 6cb527c
commit fde8467
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/components/base_component.js b/src/components/base_component.js
@@ -110,7 +110,7 @@ const create_bind_function = (args, instance_args) => (selection) => {
         if (element === null || (element && element.node
           && !document.contains(element.node()))) return
         state_handler.subscribe(me)
-        element.remove()
+        if (element) element.remove()
         element = create_element(
           args.init, format_arguments(instance_args), selection)
         render_()

diff --git a/src/manual_test.js b/src/manual_test.js
@@ -11,14 +11,14 @@ render_dashboard(`
 dashboard "Cereals":
   - h1 text: "Cereals"
   - h2 text: "By calories"
+  - dropdown my_var=foo:
+    - {"value": "foo", "text": "Foo"}
+    - {"value": "bar", "text": "Bar"}
   - bar chart:
     - attr:query: '{"columns": [(sort_by(-(.calories | tonumber)) | .[] | [.name, .calories])]}'
     - data: https://gist.githubusercontent.com/ZeningQu/6184eaf8faa533e320abc938c4738c3e/raw/40f237de825061faa8721c2293b79c46979780b4/cereals.csv
   - h2 text: "By nutritional profile"
   - 4 columns:
     - attr:query: '.[] | {"component": "rows", "data": [{"component": "text", "args": {"tagName": "h3"}, "data": .name}, {"component": "chart", "args": {"type": "pie"}, "data": {"columns": [["protein", .protein], ["carbo", .carbo], ["sugars", .sugars], ["fat", .fat]]}}]}'
     - data: https://gist.githubusercontent.com/ZeningQu/6184eaf8faa533e320abc938c4738c3e/raw/40f237de825061faa8721c2293b79c46979780b4/cereals.csv
-  - dropdown my_var=foo:
-    - {"value": "foo", "text": "Foo"}
-    - {"value": "bar", "text": "Bar"}
 `)