Fix potential CSRF circumvention with custom HTTP methods #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Just to clarify this: this is a backport of a CakePHP 3 improvement which is security-relevant in CakePHP 3. I have not tested if CakePHP 2 is actually vulnerable (and I'm not 100% convinced that it ever was). |
MarkusBauer
force-pushed
the
fix-csrf-issue
branch
from
16791d7 to
d35fa72
Compare
|
Thank you for your contribution. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attackers might be able to circumvent CakePHPs CSRF/request body protection, if the controller method does not check that the request is actually POST but uses the request body data. This issue was already patched in CakePHP 3, this PR backports the fix to CakePHP 2.
The upstream PR contains other, not so relevant changes to the CSRF token and the upstream commit refactors some unit tests. These changes are not necessary to fix this issue and are not ported.
Upstream patch: cakephp/cakephp@0f818a2
Upstream PR: cakephp/cakephp#7742