fix(SUP-46361): Transcript visibility issue with VTT captions and Label usage in Kaltura Player v7. #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
When caption doesn't have label, it doesn't appear in the transcript panel.
Root cause:
Caption data is saved with key of: {language}-{label} so where it no label it will be: language-undefined.
The compare is done between this string and the {language}-{label} coming from the engine, engine added name to caption when it's empty. so there is mismatch between the values.
Fix:
remove the label from the captionKay so comparing will be only between language.