Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(grpc): switch to gRPC CodecV2 for improved performance #944

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ijsong
Copy link
Member

@ijsong ijsong commented Dec 21, 2024

What this PR does

This PR updates the gRPC codec from v1 to v2, enhancing performance and reducing
memory allocations by utilizing a memory pool for encoded messages.

Refs:

This PR updates the gRPC codec from v1 to v2, enhancing performance and reducing
memory allocations by utilizing a memory pool for encoded messages.

Refs:
- grpc/grpc-go#7356
- vitessio/vitess#16790
@ijsong ijsong requested a review from hungryjang as a code owner December 21, 2024 12:33
Copy link

codecov bot commented Dec 21, 2024

Codecov Report

Attention: Patch coverage is 73.07692% with 7 lines in your changes missing coverage. Please review.

Project coverage is 78.77%. Comparing base (433a510) to head (da60029).

Files with missing lines Patch % Lines
pkg/rpc/codec.go 73.07% 5 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #944      +/-   ##
==========================================
- Coverage   78.95%   78.77%   -0.19%     
==========================================
  Files         180      180              
  Lines       21621    21636      +15     
==========================================
- Hits        17071    17043      -28     
- Misses       3730     3758      +28     
- Partials      820      835      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant