Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add coverpkg flag to improve test coverage reporting #938

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

ijsong
Copy link
Member

@ijsong ijsong commented Dec 13, 2024

What this PR does

  • Updated Makefile to include the coverpkg flag in test_coverage and
    test_e2e_local_coverage targets.
  • Added commands to remove and recreate coverage directories to ensure clean
    coverage data.

@ijsong ijsong requested a review from hungryjang as a code owner December 13, 2024 01:33
@ijsong ijsong force-pushed the ci_makefile_coverpkg branch from 8750981 to 4be1c6f Compare December 13, 2024 01:37
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.97%. Comparing base (51e64e9) to head (f3d28ae).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #938       +/-   ##
===========================================
+ Coverage   66.93%   78.97%   +12.03%     
===========================================
  Files         179      180        +1     
  Lines       21613    21621        +8     
===========================================
+ Hits        14467    17075     +2608     
+ Misses       6378     3728     -2650     
- Partials      768      818       +50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- Updated Makefile to include the coverpkg flag in test_coverage and
  test_e2e_local_coverage targets.
- Added commands to remove and recreate coverage directories to ensure clean
  coverage data.
@ijsong ijsong force-pushed the ci_makefile_coverpkg branch from 4be1c6f to f3d28ae Compare December 13, 2024 02:01
@ijsong ijsong merged commit 2959ac6 into main Dec 16, 2024
10 checks passed
@ijsong ijsong deleted the ci_makefile_coverpkg branch December 16, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant