Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(proto): add unit tests for LogStreamReplica #934

Open
wants to merge 1 commit into
base: test_proto_add_and_update_tests_for_proto_varlogpb_metadata.go
Choose a base branch
from

Conversation

ijsong
Copy link
Member

@ijsong ijsong commented Dec 11, 2024

What this PR does

  • Added proto/varlogpb/replica_test.go to test EqualReplicas and
    ValidReplicas functions.
  • Included various test cases to ensure correct functionality.

@ijsong ijsong requested a review from hungryjang as a code owner December 11, 2024 10:34
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.91%. Comparing base (cd27630) to head (6e0ea77).

Additional details and impacted files
@@                                        Coverage Diff                                         @@
##           test_proto_add_and_update_tests_for_proto_varlogpb_metadata.go     #934      +/-   ##
==================================================================================================
+ Coverage                                                           79.84%   79.91%   +0.06%     
==================================================================================================
  Files                                                                 179      179              
  Lines                                                               21587    21587              
==================================================================================================
+ Hits                                                                17237    17251      +14     
+ Misses                                                               3561     3551      -10     
+ Partials                                                              789      785       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ijsong ijsong force-pushed the test_proto_add_and_update_tests_for_proto_varlogpb_metadata.go branch from faec5d6 to d43ca78 Compare December 13, 2024 01:53
@ijsong ijsong force-pushed the test_proto_add_unit_tests_for_logstreamreplica branch from ed796f3 to f953940 Compare December 13, 2024 01:53
- Added `proto/varlogpb/replica_test.go` to test `EqualReplicas` and
  `ValidReplicas` functions.
- Included various test cases to ensure correct functionality.
@ijsong ijsong force-pushed the test_proto_add_and_update_tests_for_proto_varlogpb_metadata.go branch from d43ca78 to cd27630 Compare December 13, 2024 02:01
@ijsong ijsong force-pushed the test_proto_add_unit_tests_for_logstreamreplica branch from f953940 to 6e0ea77 Compare December 13, 2024 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant