test(proto): add and update tests for proto/varlogpb/metadata.go #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## refactor_remove_unnecessary_code_from_proto_varlogpb_log_entry #933 +/- ##
==================================================================================================
+ Coverage 79.15% 79.84% +0.69%
==================================================================================================
Files 179 179
Lines 21607 21587 -20
==================================================================================================
+ Hits 17102 17237 +135
+ Misses 3694 3561 -133
+ Partials 811 789 -22 ☔ View full report in Codecov by Sentry. |
ijsong
force-pushed
the
test_proto_add_and_update_tests_for_proto_varlogpb_metadata.go
branch
from
b98a528 to
faec5d6
Compare
ijsong
force-pushed
the
refactor_remove_unnecessary_code_from_proto_varlogpb_log_entry
branch
from
382277e to
a62e2db
Compare
ijsong
force-pushed
the
test_proto_add_and_update_tests_for_proto_varlogpb_metadata.go
branch
from
faec5d6 to
d43ca78
Compare
- Removed unused functions from metadata.go - Added comprehensive unit tests for metadata.go and metadata_test.go - Improved test coverage for various scenarios
ijsong
force-pushed
the
refactor_remove_unnecessary_code_from_proto_varlogpb_log_entry
branch
from
a62e2db to
1001a00
Compare
ijsong
force-pushed
the
test_proto_add_and_update_tests_for_proto_varlogpb_metadata.go
branch
from
d43ca78 to
cd27630
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does