Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add missing test for proto/snpb.ValidateTopicLogStream #916

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ijsong
Copy link
Member

@ijsong ijsong commented Nov 22, 2024

Add missing test for proto/snpb.ValidateTopicLogStream.

@ijsong ijsong requested a review from hungryjang as a code owner November 22, 2024 00:48
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.99%. Comparing base (f3d28ae) to head (36e61c6).

Additional details and impacted files
@@                   Coverage Diff                    @@
##           ci_makefile_coverpkg     #916      +/-   ##
========================================================
+ Coverage                 78.97%   78.99%   +0.01%     
========================================================
  Files                       180      180              
  Lines                     21621    21621              
========================================================
+ Hits                      17075    17079       +4     
+ Misses                     3728     3722       -6     
- Partials                    818      820       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ijsong ijsong force-pushed the tests_validate_topic_logstream branch from e92b816 to a0f2401 Compare December 13, 2024 01:53
@ijsong ijsong changed the base branch from main to ci_makefile_coverpkg December 13, 2024 01:54
- Updated Makefile to include the coverpkg flag in test_coverage and
  test_e2e_local_coverage targets.
- Added commands to remove and recreate coverage directories to ensure clean
  coverage data.
@ijsong ijsong force-pushed the ci_makefile_coverpkg branch from 4be1c6f to f3d28ae Compare December 13, 2024 02:01
@ijsong ijsong force-pushed the tests_validate_topic_logstream branch from a0f2401 to 36e61c6 Compare December 13, 2024 02:01
Base automatically changed from ci_makefile_coverpkg to main December 16, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant