-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): use go.uber.org/mock/mockgen instead of github.com/golang/mock/mockgen #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 23, 2023
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
ijsong
force-pushed
the
update_gomock
branch
from
November 23, 2023 05:40
81037ba
to
a5a68fc
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## bump_pebble_from_7ef7553fd9e1_to_6682fd5e8763 #640 +/- ##
=================================================================================
+ Coverage 61.20% 61.28% +0.08%
=================================================================================
Files 144 144
Lines 19306 19306
=================================================================================
+ Hits 11816 11832 +16
+ Misses 6889 6881 -8
+ Partials 601 593 -8 ☔ View full report in Codecov by Sentry. |
ijsong
force-pushed
the
bump_pebble_from_7ef7553fd9e1_to_6682fd5e8763
branch
from
November 26, 2023 10:33
a37cc7b
to
741e9d9
Compare
ijsong
force-pushed
the
update_gomock
branch
from
November 26, 2023 10:33
a5a68fc
to
f4503ba
Compare
ijsong
force-pushed
the
bump_pebble_from_7ef7553fd9e1_to_6682fd5e8763
branch
from
December 1, 2023 08:07
741e9d9
to
f6cf2db
Compare
This was referenced Dec 1, 2023
hungryjang
approved these changes
Dec 26, 2023
ijsong
force-pushed
the
bump_pebble_from_7ef7553fd9e1_to_6682fd5e8763
branch
from
December 28, 2023 05:52
f6cf2db
to
424eee0
Compare
ijsong
force-pushed
the
update_gomock
branch
from
December 28, 2023 05:52
1106bf6
to
4874280
Compare
…g/mock/mockgen The `github.com/golang/mock/mockgen` is deprecated now. So this PR changes it to `go.uber.org/mock/mockgen`. See: golang/go#61017
ijsong
force-pushed
the
bump_pebble_from_7ef7553fd9e1_to_6682fd5e8763
branch
from
January 2, 2024 00:19
424eee0
to
73bc5f6
Compare
Base automatically changed from
bump_pebble_from_7ef7553fd9e1_to_6682fd5e8763
to
main
January 2, 2024 01:19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
The
github.com/golang/mock/mockgen
is deprecated now. So this PR changes it togo.uber.org/mock/mockgen
.Anything else
See: golang/go#61017