Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): use go.uber.org/mock/mockgen instead of github.com/golang/mock/mockgen #640

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

ijsong
Copy link
Member

@ijsong ijsong commented Nov 23, 2023

What this PR does

The github.com/golang/mock/mockgen is deprecated now. So this PR changes it to go.uber.org/mock/mockgen.

Anything else

See: golang/go#61017

@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (73bc5f6) 61.20% compared to head (d5ca139) 61.28%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                                Coverage Diff                                @@
##           bump_pebble_from_7ef7553fd9e1_to_6682fd5e8763     #640      +/-   ##
=================================================================================
+ Coverage                                          61.20%   61.28%   +0.08%     
=================================================================================
  Files                                                144      144              
  Lines                                              19306    19306              
=================================================================================
+ Hits                                               11816    11832      +16     
+ Misses                                              6889     6881       -8     
+ Partials                                             601      593       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ijsong ijsong force-pushed the bump_pebble_from_7ef7553fd9e1_to_6682fd5e8763 branch from a37cc7b to 741e9d9 Compare November 26, 2023 10:33
@ijsong ijsong force-pushed the bump_pebble_from_7ef7553fd9e1_to_6682fd5e8763 branch from 741e9d9 to f6cf2db Compare December 1, 2023 08:07
@ijsong ijsong force-pushed the bump_pebble_from_7ef7553fd9e1_to_6682fd5e8763 branch from f6cf2db to 424eee0 Compare December 28, 2023 05:52
…g/mock/mockgen

The `github.com/golang/mock/mockgen` is deprecated now. So this PR changes it to
`go.uber.org/mock/mockgen`.

See: golang/go#61017
@ijsong ijsong force-pushed the bump_pebble_from_7ef7553fd9e1_to_6682fd5e8763 branch from 424eee0 to 73bc5f6 Compare January 2, 2024 00:19
@ijsong
Copy link
Member Author

ijsong commented Jan 2, 2024

Merge activity

  • Jan 1, 8:00 PM: @ijsong started a stack merge that includes this pull request via Graphite.
  • Jan 1, 8:21 PM: @ijsong merged this pull request with Graphite.

Base automatically changed from bump_pebble_from_7ef7553fd9e1_to_6682fd5e8763 to main January 2, 2024 01:19
@ijsong ijsong merged commit 5237f8f into main Jan 2, 2024
16 checks passed
@ijsong ijsong deleted the update_gomock branch January 2, 2024 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants