경북대 BE_이동원_1주차 과제(1단계 ~ 3단계) #204
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khj68
requested changes
Jun 30, 2024
| this.dataSource = dataSource; | ||
| } | ||
|
|
||
| @Bean |
| import org.springframework.web.bind.annotation.PathVariable; | ||
| import org.springframework.web.bind.annotation.RequestMapping; | ||
|
|
||
| @Controller |
There was a problem hiding this comment.
이미 해당 어노테이션을 통해 빈 등록이 되니 config에서는 지워주세요.
| import org.springframework.web.bind.annotation.GetMapping; | ||
|
|
||
| @Controller | ||
| public class ErrorController { |
| } | ||
|
|
||
| // 모든 제품을 가져오는 엔드포인트 | ||
| @GetMapping("") |
| public ResponseEntity<Product> putProduct(@RequestBody ProductForm form, @PathVariable Long id) { | ||
| Product product = new Product(form); // ProductForm을 Product로 변환 | ||
| Product result = repository.edit(id, product); | ||
| if (result != null) { |
There was a problem hiding this comment.
에러 처리가 보일러플레이트처럼 반복되는 것으로 보입니다.
global exception handler 의 도입을 추천드립니다.
| @PostMapping(path = "", consumes = "application/json") | ||
| public ResponseEntity<Product> postProduct(@RequestBody ProductForm form) { | ||
| Product product = new Product(form); // ProductForm을 Product로 변환 | ||
| Product result = repository.save(product); |
There was a problem hiding this comment.
컨트롤러 단에서 바로 로직이 실행되고 있습니다.
특정 클래스를 통해 controller에서 repository를 참조하지 않는 것을 추천드립니다.
| } | ||
|
|
||
| // 특정 ID의 제품을 수정하는 엔드포인트 | ||
| @PutMapping(path = "/{id}", consumes = "application/json") |
|
|
||
| @Test | ||
| @DisplayName("존재하지 않는 ID 삭제") | ||
| public void delete_nonexistent() { |
There was a problem hiding this comment.
테스트 코드 아주 좋습니다.
// given
// when
// then
이와 같은 양식을 익혀둔다면 추후 테스트 작성시 용이합니다.
실무에서도 해당 양식을 주석으로 적어 통일성과 유지보수성을 높이고 있습니다.
|
conflict 도 resolve 부탁드립니다! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.