-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
전남대 BE_조홍식_1주차 과제(1~3단계) #189
Open
Daolove0323
wants to merge
25
commits into
kakao-tech-campus-2nd-step2:main
Choose a base branch
from
Daolove0323:step3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
products를 service로 이동 비지니스 로직 모두 service로 이동 후, service의 메서드를 호출하도록 변경
admin, add-form, edit-form에 적용되는 css 스타일
service에서 다루던 products 데이터들을 h2 데이터베이스로 다룬다. db의 ddl, dml 명령어는 repository 클래스의 메소드를 통해 호출하고, service의 비지니스 로직들은 repository의 메서드를 통해 처리한다.
products 멤버 변수를 지우고, 비지니스 로직들은 레포지토리 객체를 통해 처리한다.
add버튼을 누르면 에러가뜨는 버그를 수정
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
스텝2에서는 service에서 데이터를 저장하고 처리했는데, 스텝3로 넘어오면서 repository 클래스를 추가하고 db에 접근하도록 하였습니다.
service의 모든 비지니스 로직은 repository를 통해 수행되도록 했는데, spring을 처음 다루다보니 이게 맞는 설계방식인지 잘 모르겠습니다.
잘 모르다보니 대부분의 과정을 구글링을 통해 해결했는데, 코드의 불필요한 점이나, 요구사항을 제대로 만족하지 못하는 부분, 구식코드(요즘에는 잘쓰이지 않는 방식) 이 있는지 궁금합니다!