전남대 BE_안원모 1주차 과제(2단계) #183
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkeugine
requested changes
Jun 29, 2024
|
|
||
| @GetMapping | ||
| public List<Product> getProducts() { | ||
| return productService.findAllProducts(); |
There was a problem hiding this comment.
ResponseEntity 부분이 사라졌네요.
제가 물음표 빌런이라, 이를 왜 없애주셨는지 역시 궁금해요 :)
Comment on lines
11
to
14
| @Autowired | ||
| public ProductService(ProductRepository productRepository) { | ||
| this.productRepository = productRepository; | ||
| } |
There was a problem hiding this comment.
생성자를 통한 bean 주입을 할 때 보통 @Autowired 를 빼주셨는데,
이부분만 어노테이션을 달아주신 이유가 있나요?
| } | ||
| return "redirect:/products"; | ||
| } | ||
| @GetMapping("/products/edit/{id}") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
코드 리뷰 시, 멘토님이 중점적으로 리뷰해줬으면 하는 부분
전체적으로 아직 Spring의 이해도가 낮아서 제대로 수행했는지 모르겠습니다.. 전반적으로 확인해주시면 감사하겠습니다!
그리고 잘 모르다보니 스스로 구현했다기 보다는 구글링에 의존하여 하였는데,
1.제대로 구현한 것인지
2.코드에 불필요한 점은 없는지
궁금합니다.