경북대 BE_김영인 6주차 과제(3단계) #324
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gongdongho12
requested changes
Aug 4, 2024
Comment on lines
+50
to
+53
| - [x] member entity에 point 추가 | ||
| - [x] 특정 회원의 point 조회 | ||
| - [x] 특정 회원에 point 추가 |
There was a problem hiding this comment.
포인트를 만들었는데 사용할 방안은 FE 분들과 싱크 완료되었을까요?
Comment on lines
+19
to
+20
| @Column(columnDefinition = "integer default 0") | ||
| private Integer point; |
Comment on lines
+31
to
+33
| public void addPoint(int point){ | ||
| this.point += point; | ||
| } |
Comment on lines
+65
to
+70
| public PointResponse addPoint(Long user_id, PointRequest pointRequest) { | ||
| Member member = getMemberById(user_id); | ||
| member.addPoint(pointRequest.getPoint()); | ||
| memberRepository.save(member); | ||
| return new PointResponse(member); | ||
| } |
There was a problem hiding this comment.
한 계정으로 웹 사이트에 접속을 두명이 했을 때, 포인트 충전을 각각 10씩 하면 어떤 결과가 일어날까요?
가져오는 시점과 업데이트 시점이 달라질 수 있지 않을까요?
이부분 관련해서 스레드 나눠서 동시성 테스트랑 이 로직에 트랜잭션 같이 적용 부탁드려요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Point 기능을 추가하는 3단계 과제 입니다.