전남대 BE_지연우 4주차 과제(step1,2,3) #180
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
step2 기능 요구사항 작성
상품 저장시 옵션이 제대로 저장되지 않는 오류 수정
상품 조회시 상품의 옵션 정보까지 같이 조회하도록 수정
STEP3 기능 요구사항 작성
상품의 각 옵션의 수량도 알려주도록 수정
seungy0
approved these changes
Jul 21, 2024
Comment on lines
+49
to
+52
| public void changeCategoryName(@RequestBody CategoryForm categoryForm, @PathVariable Long id) { | ||
| categoryForm.setId(id); | ||
| categoryService.updateCategory(categoryForm); | ||
| } |
There was a problem hiding this comment.
Suggested change
| public void changeCategoryName(@RequestBody CategoryForm categoryForm, @PathVariable Long id) { | |
| categoryForm.setId(id); | |
| categoryService.updateCategory(categoryForm); | |
| } | |
| public void changeCategoryName(@RequestBody CategoryForm categoryForm, @PathVariable Long id) { | |
| categoryService.updateCategory(id, categoryForm); | |
| } |
이런 방식은 어떨까요?
| @NotBlank | ||
| private String name; | ||
|
|
||
| @JsonCreator |
Comment on lines
+11
to
+14
| public CategoryParam(Category category) { | ||
| this.id = category.getId(); | ||
| this.name = category.getName(); | ||
| } |
| .orElseThrow(CategoryNotFoundException::new); | ||
| } | ||
|
|
||
| public void updateCategory(CategoryForm categoryForm) { |
There was a problem hiding this comment.
옵션만을 조회하는 경우는 없을까요?
개발자 도구를 사용해 실제 카카오 선물하기에서 API를 어떻게 구성하고 있는지 살펴보시는 것도 좋겠습니다.
Comment on lines
+40
to
+41
| @OneToMany(mappedBy = "product", cascade = CascadeType.ALL) | ||
| private List<Option> options = new ArrayList<>(); |
There was a problem hiding this comment.
트랜잭션을 걸지 않으면 예상과는 다른 결과가 나올 수 있습니다.
일부에는 걸고, 일부에는 걸지 않은 이유가 궁금합니다.
Comment on lines
+64
to
+68
| private void validateDuplicatedName(Long productId, OptionForm optionForm) { | ||
| if (optionRepository.existsByProductIdAndName(productId, optionForm.getName())) { | ||
| throw new IllegalArgumentException("옵션 이름은 중복될 수 없습니다."); | ||
| } | ||
| } |
There was a problem hiding this comment.
db에서 unique 키를 거는 방법도 있습니다.
현재와 같이 구성하면 validation 이후에 option을 수정하기 전에 같은 이름의 옵션이 추가될 수 있습니다.
| @Service | ||
| public class CategoryService { | ||
|
|
||
| private final JpaCategoryRepository categoryRepository; |
There was a problem hiding this comment.
Suggested change
| private final JpaCategoryRepository categoryRepository; | |
| private final CategoryRepository categoryRepository; |
이렇게 작성해도 잘 작동되게 해주세요~
스프링의 핵신 기능 DI/IoC를 올바르게 사용하지 않고 계세요.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
리뷰 잘부탁드립니다!