충남대 FE_임세빈_1주차 과제 #73
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
README.md에 기능 목록 정리
orangehouse202
approved these changes
Jul 1, 2024
There was a problem hiding this comment.
고생하셨습니다~
STEP2 Grid 컴포넌트를 구현할 때, children에 JSX 요소 자체를 넣고 싶었는데 해결방법을 찾지 못해 string 형의 배열로 사용하였습니다. element를 배열에 넣어 구현하는 방법이 궁금합니다.
ReactNode를 타입으로 받아서 그대로 렌더하면 됩니다. https://react.dev/reference/react/Children 요 문서를 참고해보세요!
| /** | ||
| * true : 활성화느낌 / false : 비활성화느낌 | ||
| */ | ||
| theme?: boolean; |
There was a problem hiding this comment.
theme이 boolean인건 다소 어색하게 느껴져요!
차라리 'primary' | 'light' 이런식의 네이밍이 더 직관적일 것 같아요
| amount = 1, | ||
| }: GoodsItemProps) => { | ||
| return ( | ||
| <div style={{width:'120px'}}> |
Comment on lines
+18
to
+26
| if (ratio == "square") { | ||
| ratio = 1 | ||
| } | ||
| let borderRadius: string; | ||
| if (radius == "circle") { | ||
| borderRadius = '50%' | ||
| } else { | ||
| borderRadius = `${radius}px` | ||
| } |
Comment on lines
+7
to
+8
| ratio? : number | 'auto' | 'square'; | ||
| radius? : number | "circle" |
There was a problem hiding this comment.
- 어떤 역할을 하는 Props들인지 직관적으로 이해하기 어려워요
- 내부 동작을 예측할 수 없어요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요, 1주차 과제 PR 드립니다!
✅ STEP1
✅ STEP2
✅ STEP3
❓ 궁금한 점
STEP2 Grid 컴포넌트를 구현할 때, children에 JSX 요소 자체를 넣고 싶었는데 해결방법을 찾지 못해 string 형의 배열로 사용하였습니다. element를 배열에 넣어 구현하는 방법이 궁금합니다.
감사합니다!