Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

부산대 Android_이지은 3주차 1단계 #98

Open
wants to merge 7 commits into
base: jieunyume
Choose a base branch
from
Open

부산대 Android_이지은 3주차 1단계 #98

wants to merge 7 commits into from

Conversation

JieunYume
Copy link

@JieunYume JieunYume commented Jul 12, 2024 •
edited
Loading

어려웠던 점

  • suspend 함수, 코루틴 개념이 헷갈렸다.
    • LiveData 변수에 저장된 데이터의 사이즈가 계속 0으로 떴다. 왜냐하면 API 통신으로 받아온 데이터를 LiveData 변수에 저장하는 작업이 끝나지 않았는데, LiveData 변수에 저장된 데이터의 사이즈에 접근하려고 했기 때문이다.

중점적으로 봐주셨으면 좋겠는 부분

  • 데이터를 받아올 때 비동기적으로 잘 받아왔는지 확인해주셨으면 좋겠습니다!

실행 화면

@bigstark bigstark assigned bigstark and unassigned bigstark Jul 14, 2024
@bigstark bigstark self-requested a review July 14, 2024 15:19
bigstark
bigstark approved these changes Jul 14, 2024
View reviewed changes
Copy link

@bigstark bigstark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

지은님 step1 고생 많으셨어요. 비동기 처리에 대해서 잘 처리해주셨지만, 에러 처리에 대한 부분 고민을 조금만 해주시면 좋을 것 같습니다 :)

app/build.gradle.kts Show resolved Hide resolved
app/src/main/java/campus/tech/kakao/map/LocationAdapter.kt Outdated Show resolved Hide resolved
app/src/main/java/campus/tech/kakao/map/LocationRemoteRepository.kt Show resolved Hide resolved
app/src/main/java/campus/tech/kakao/map/LocationRemoteRepository.kt Show resolved Hide resolved
app/src/main/java/campus/tech/kakao/map/LocationViewModel.kt Show resolved Hide resolved
app/src/main/java/campus/tech/kakao/map/SearchFromKeywordResponse.kt Show resolved Hide resolved
app/src/main/java/campus/tech/kakao/map/retrofit/KakaoAPI.kt Show resolved Hide resolved
app/src/main/java/campus/tech/kakao/map/retrofit/RetrofitInstance.kt Show resolved Hide resolved
app/src/main/java/campus/tech/kakao/map/LocationRemoteRepository.kt Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigstark bigstark bigstark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JieunYume @bigstark