[강원대 안드로이드 주민철] 3주차 과제 스텝 2 #73
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
필요 없는 데이터는 주석화 함.
로컬 API로 검색을 하기에 더이상 필요치 않음.
기존의 PlaceAdapter를 카카오 로컬 데이터를 사용하는 DocumentAdapter로 변경
사용하지 않는 함수 제거
기존 Place 관련 기능들을 Document로 변경
기존 Place 관련 기능들을 Document로 변경
애플리케이션을 통해 키 해시 값 구하고 앱 키 추가
앱을 처음 실행하면 지도 화면을 표시한다.
검색창을 선택하면 검색 화면으로 이동한다. 검색 화면에서 뒤로 가기를 하면 지도 화면으로 돌아온다.
mkSpace
requested changes
Jul 12, 2024
app/src/main/java/campus/tech/kakao/map/DBHelper/SearchWordDbHelper.kt
Outdated
Show resolved
Hide resolved
좀 더 명확하게 바꿈.
mkSpace
approved these changes
Jul 14, 2024
mkSpace
reviewed
Jul 14, 2024
| interface RetrofitService { | ||
| @GET("keyword.json") | ||
| fun requestPlaces( | ||
| @Header("Authorization") Authorization: String, |
There was a problem hiding this comment.
Suggested change
| @Header("Authorization") Authorization: String, | |
| @Header("Authorization") authorization: String, |
|
패키지명이 대문자로 시작하는 부분도 Kotlin Convention에 벗어나는 네이밍 입니다. 그 부분도 같이 수정 부탁드려요 |
|
Adapter, DBHelper, DTO 등의 폴더명 입니다 |
아하! 그렇군요. 이번 주차 과제에서 바꾸도록 하겠습니다. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.