전남대 Android_최영빈_5주차 과제_step1 #62
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omjoonkim
requested changes
Jul 28, 2024
|
|
||
| class DataSearchActivity : AppCompatActivity(), RecentAdapterListener, SearchAdapterListener { | ||
| private lateinit var searchViewModel: SearchViewModel | ||
| private lateinit var recentViewModel: RecentViewModel | ||
| private lateinit var recentViewModel: DBViewModel |
There was a problem hiding this comment.
변수 이름과 타입의 매칭이 잘되어있지 않은 것 같아요. 적절하게 네이밍을 변경해보세요.
| @@ -50,7 +52,9 @@ class DataSearchActivity : AppCompatActivity(), RecentAdapterListener, SearchAda | |||
|
|
|||
| //ViewModel 생성 | |||
| searchViewModel = ViewModelProvider(this)[SearchViewModel::class.java] | |||
| recentViewModel = ViewModelProvider(this)[RecentViewModel::class.java] | |||
| dbRepo = SearchHistoryRepository(this) | |||
| recentViewModel = | |||
There was a problem hiding this comment.
Hilt를 통한 의존성 주입이 적용되어있지 않네요. Hilt를 통해 각 객체가 생성되어 뷰모델이 만들어지도록 변경해보세요.
| import campus.tech.kakao.map.dataRepository.SearchHistoryRepository | ||
| import kotlinx.coroutines.launch | ||
|
|
||
| class DBViewModel(private val searchHistoryRepo: SearchHistoryRepository) : ViewModel() { |
There was a problem hiding this comment.
DBViewModel이라는 이름 대신 뷰의 추상화 개념이 보여지는 이름으로 변경해보세요.
|
안녕하세요 영빈님~!. 과제의 요구사항인 Hilt적용이 거의 되어있지 않은 것 같아요. 적용하신 뒤에 다시 리뷰요청 해주세요. |
|
@omjoonkim Hilt 적용하고 step2 PR에도 반영하였습니다 |
This was referenced Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
코드 작성하면서 어려웠던 점
멘토님이 중점적으로 리뷰해 주셨으면 하는 부분
과제 제출 프로세스를 안내받았음에도 이렇게 매번 PR이 늦어 무척 죄송한 마음입니다. 정말 죄송합니다!