Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
경북대Android_정수현_1주차 과제 #37
base: jsh00325
Are you sure you want to change the base?
경북대Android_정수현_1주차 과제 #37
Changes from 16 commits
62588b0
037366f
fd20c6d
9cca3c5
9946f38
7ea2ec6
763bf16
4cfbaa7
7c70c0c
2eafb0f
4e22289
e10a86e
c60d8dd
7066116
347235d
0e2ad0a
39e966c
3b98422
7df2bd2
8637994
08a428a
b45cc13
2033f07
a4cecd4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 부분을 말씀 해주신거 같은데 나쁘지 않은 방법으로 보입니다.
다만 요구사항이 더 복잡해져서 visibility가 여러군데에서 바뀐다면
it.email
이 null일때 visibility=GONE 처리가 누락될 가능성도 있을거 같아요항상 visibility 처리를 하도록 이렇게 바꿔보는 방법도 있을거 같습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2033f07
/ 리뷰 참고하여 다음과 같이 수정하였습니다!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오 좋네요 👍
제가 보기엔 깔끔해진거 같은데 어떠세요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
가독성도 더 좋아진 것 같고, 항상 조건에 따라 상태를 지정할 수 있어 좋은 것 같습니다!!