[부산대 Android_김민혁] 1주차 미션 제출합니다. #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added README.md to provide basic project information and usage instructions. This commit introduces the project overview, features, and usage instructions in the README.md file.
This commit establishes the basic structure of the layout and integrates essential UI components for further development.
Added face.xml drawable resource to serve as the application logo. Implemented name input form in the main layout XML file.
Implemented phone number and email input forms in the main layout XML file.
… string resources
… field interactions. - Designed the main layout with input fields for name, phone number, and email. - Integrated 'More' button for expanding additional options, pending further functionality. This commit lays the foundation for handling core features of capturing contact information and basic interaction flows in MainActivity.
…vity Added birthday input functionality using DatePickerDialog in MainActivity. - Integrated a DatePickerDialog to allow users to select a birthdate. - Implemented logic in MainActivity to capture and process selected date information.
- Introduced RadioButtons for gender selection (male/female) within MainActivity layout. - Integrated EditText for capturing optional memo input from users. - Updated MainActivity to include variables for storing selected gender and memo text.
…gics - Added Confirmation dialog for navigating back on cancel button click - Added Logic to handle empty list case - Added Intents for data passing
- Implemented ContactActivity to display a list of contacts using RecyclerView. - Added Intent communication with AddContactActivity. - Added new aitivities into AndroidManifest.xml
- Implemented ContactAdapter to populate RecyclerView in ContactList. - Provides data binding between contact data and UI elements.
- Introduced Contact.kt as a data class representing ContactItem data structure. - Implemented contact_item.xml layout for displaying individual ContactItem in RecyclerView. - Added circle_background.xml drawable for styling circular backgrounds in contact_item.
…led contact information - Implemented ContactDetailActivity to display detailed information when a ContactItem is clicked. - Created activity_contact_detail.xml layout to show specific details such as name, phone, email, etc.
kyleidea1
changed the title
JSpiner
requested changes
Jul 1, 2024
| @@ -1 +1,62 @@ | |||
| # android-contacts | |||
|
|
|||
There was a problem hiding this comment.
README.md를 잘 작성해주셨군요 🎉
하지만 코드리뷰 요청을 해주실땐 '변경사항' 단위로 리뷰를 하다보니
PR 본문에 어떤작업이고 어떤 내용이 있는지를 잘 설명 해주시면 리뷰어가 리뷰하기 더 편할거에요!
| } | ||
| } | ||
|
|
||
| override fun onBackPressed() { |
There was a problem hiding this comment.
onBackPressed 에 대해서 warning이 나오실거에요 한번 확인 해보시겠어요?
| val day = calendar.get(Calendar.DAY_OF_MONTH) | ||
|
|
||
| val datePickerDialog = DatePickerDialog(this, { _, selectedYear, selectedMonth, selectedDay -> | ||
| val selectedDate = "$selectedYear-${selectedMonth + 1}-$selectedDay" |
There was a problem hiding this comment.
string template에 연산이 들어가있으니 결과물을 예측하기 어려워진거 같아요
연산이 안들어가게 할순 없을까요?
| class ContactAdapter(private val context: Context, private val contactList: List<Contact>) : | ||
| RecyclerView.Adapter<ContactAdapter.ContactViewHolder>() { | ||
|
|
||
| interface OnItemClickListener { |
There was a problem hiding this comment.
SAM(Single Abstract Method)를 구현하셔서 사용하셨군요!
이렇게써도 좋지만 kotlin에서는 람다식을 이용하면 좀 더 간단하게 구현할수도 있습니다.
| val memoSection = findViewById<View>(R.id.memo_section) | ||
|
|
||
| val intent = intent | ||
| val name = intent.getStringExtra("name") |
There was a problem hiding this comment.
intent.getXXX()로 받는 key들이 여러곳에서 사용되고 있네요
상수로 빼내는건 어떨까요?
|
|
||
| private fun checkEmptyState() { | ||
| val emptyText = findViewById<TextView>(R.id.empty_text) | ||
| emptyText.visibility = if (contacts.isEmpty()) View.VISIBLE else View.GONE |
There was a problem hiding this comment.
isVisible 익스텐션을 이용하면 좀 더 간단하게 구현할수 있을거에요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
감사합니다!