[충남대 Android_전영주] 1단계 미션 제출합니다. #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aengzu
commented
Jun 26, 2024
•
aengzu
commented
- 1단계 XML 제작 및 연락처 추가 기능 완성하였습니다.
- XML 제작 시 아이폰 UI 보면서 했습니다.
- Added attribute: contacts (mutableListOf<Contact>) - Added methods: add, delete, and fetch contacts
- Added more options icon - Added default profile image - Added down arrow icon
- Added EditText for name with InputType text - Added EditText for phoneNum with InputType=number|phone - Added EditText for email with InputType=textEmailAddress - Added LinearLayout for moreButton and its icon - Added EditText for birthday with InputType=none and clickable=true (Visible=gone) - Added RadioGroup for gender(Visible=gone) - Added EditText for memo with inputType=textMultiLine and singleLine="false"(Visible=gone)
- Added moreButton setOnClickListener - Added findViewById
- Added saveButton clickListener - Added getSelectedRadioButton function - Added check function if name and phoneNum are not Empty. - Added ViewModel (액티비티 라이프사이클보다 연락처 데이터의 수명주기가 길어야해서) -Added saveContact function
InyoungAum
requested changes
Jun 28, 2024
| val contact = Contact(name, phoneNum, email, birth, gender, memo) | ||
|
|
||
| if (checkTerms(name, phoneNum)) { | ||
| saveContact(contact) |
There was a problem hiding this comment.
save이후에도 clearFields를 호출해서 초기화 시켜주는 것이 좋을 것 같습니다.
저장후에도 데이터가 남아있어 취소를 눌렀을때 저장이 취소 될 것 같은 느낌을 줍니다.
| datePickerDialog.show() | ||
| } | ||
|
|
||
| private fun checkTerms(name: String, phoneNum: String): Boolean { |
There was a problem hiding this comment.
checkTerms 함수는
-
이름과 번호를 체크하는기능
-
데이터가 충분하지 않을때 토스트를 띄우는 기능
이렇게 두가지 역할을 하고 있는데요
checkTerms을 사용하는 부분에서 false가 나왔을때 토스트를 띄우도록 하여 함수가 하나의 기능만 하도록 구현하면 더욱 좋을 것 같습니다.
| } | ||
|
|
||
|
|
||
| } |
There was a problem hiding this comment.
실무에서는 indent를 중요하게 생각하고 lint라는 기능들을 사용하여 따로 체크를 하기도 합니다.
그 이유는 리뷰시 불필요한 라인 변경을 방지하여 리뷰의 효율을 높이기 위함인데요
커밋전에 Mac OS 기준 option + cmd + l 을 누르면 라인 정리가 되니 이후 과제에 참고 부탁드립니다!
kold-brewed
pushed a commit
that referenced
this pull request
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.