-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make kairos-sysext be generic enough to include on all flavors #477
Conversation
f0586f2
to
eda60c4
Compare
Test ongonig for this: kairos-io/kairos#1904 |
eda60c4
to
518df4d
Compare
Expected: On systems that do not support systemd-sysext becuase they are older, its not installed, on systems that support it, it is. Outcome of the test: on ubuntu-20-lts (no sysext available): on opensuse-tumbleweed (sysext available), So as a side effect of this generic approach of adding if its there, we GAIN sysext support in all newer distros :D |
It will not install the systemd-sysext package if the binary is not there Signed-off-by: Itxaka <[email protected]>
518df4d
to
2dad077
Compare
|
||
# called by dracut | ||
check() { | ||
return 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This indicates to dracut to always include the module
files=( "${dracutbasedir}"/modules.d/??systemd-sysext ) | ||
[ "${#files[@]}" -ge 2 ] && return 1 | ||
if [ -d "${files[0]}" ]; then | ||
echo "systemd-sysext" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is what brings the systemd-sysext module as dependent, so it includes on systems that have botht he binary and the dracut module available, otherwise this module depends on nothing and its basically an empty thing that does nothing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice
It will not install the systemd-sysext package if the binary is not there