Make sure /etc/machine-id is generate as early as possible in systemd #1178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes kairos-io/kairos#3038 Deprecates mudler/yip#193 Signed-off-by: Dimitris Karakasilis <[email protected]>
jimmykarily
commented
Dec 13, 2024
| # https://www.freedesktop.org/software/systemd/man/latest/systemd-machine-id-commit.service.html | ||
| # https://www.freedesktop.org/software/systemd/man/latest/systemd-machine-id-setup.html | ||
| # Mask the commit service to avoid systemd messing with machine-id. | ||
| - ln -s /dev/null /etc/systemd/system/systemd-machine-id-commit.service |
There was a problem hiding this comment.
Normally, since this service will kick in later, it should have no effect, so we shouldn't need to mask it but better safe than sorry?
There was a problem hiding this comment.
mmmh, cant we mask it on the base images directly? or use the systemctl plugin? https://github.com/mudler/yip?tab=readme-ov-file#stagesstageidstepnsystemctl
There was a problem hiding this comment.
Also, we should run it on the rootfs, which is the earliest stage we got I think, so we mask it asap.
There was a problem hiding this comment.
Good points, pushed a commit
#1178 (comment) Signed-off-by: Dimitris Karakasilis <[email protected]>
Signed-off-by: Dimitris Karakasilis <[email protected]>
Itxaka
approved these changes
Dec 13, 2024
mudler
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes kairos-io/kairos#303
Deprecates mudler/yip#193