Pull data sources at install #1137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Corrado <[email protected]>
Signed-off-by: Ben Corrado <[email protected]>
Signed-off-by: Ben Corrado <[email protected]>
jimmykarily
reviewed
Nov 12, 2024
jimmykarily
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Other than my comment, the rest looks great :). Thanks @bencorrado!
You should have permissions to add to the pr, if you have time to make that change, you don't need to wait for me, I am already in bed for the night. |
to let the CI build when a new version appears Signed-off-by: Dimitris Karakasilis <[email protected]>
Signed-off-by: Dimitris Karakasilis <[email protected]>
because that's what the build script understands (and removes) Signed-off-by: Dimitris Karakasilis <[email protected]>
jimmykarily
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the way we pull in datasources.