Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing variant & k3s version to uki pipeline #2984

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

mauromorales
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2983

@mauromorales mauromorales requested a review from a team November 4, 2024 20:31
@mauromorales mauromorales self-assigned this Nov 4, 2024
Copy link
Member

@Itxaka Itxaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we? Or do we want to push using sysextensions for this?

@mauromorales
Copy link
Member Author

@Itxaka we can push for sysext for this, but meanwhile, both core and standard are broken. I don't mind removing the standard one if we want to do this via sysext, but I'm not sure how that would work because we'd need to have those signed

@Itxaka
Copy link
Member

Itxaka commented Nov 5, 2024

@Itxaka we can push for sysext for this, but meanwhile, both core and standard are broken. I don't mind removing the standard one if we want to do this via sysext, but I'm not sure how that would work because we'd need to have those signed

I don't get how this is broken and how adding k3s makes it work?

Also sysext are also signed, same as the images and everything UKI, so not sure what that has to do with anything? We provide base artifacts, unsigned and the user needs to build based on those and sign those to work. I don't get how providing k3s in the base image would improve that ?

Also, doesn't this make the image bigger so it potentially makes it difficult-er to boot on stupid EFI firmwares that have EFI size restrictions?

@mauromorales
Copy link
Member Author

Ok merging this and we can have a look at the test in a different PR plus have a ticket for sysext

@mauromorales mauromorales merged commit 965a898 into master Nov 7, 2024
69 of 71 checks passed
@mauromorales mauromorales deleted the 2983-uki-standard branch November 7, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Standard UKI image doesn't contain a kairos image
2 participants