Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin dependencies #2677

Closed
wants to merge 1 commit into from
Closed

Pin dependencies #2677

wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jun 28, 2024

Mend Renovate

This PR contains the following updates:

Package Type Update Change
alpine stage pinDigest -> af4785c
alpine final pinDigest -> af4785c
alpine final pinDigest -> b89d9c9
debian stage pinDigest -> 45461c0
fedora stage pinDigest -> 64cd00a
quay.io/kairos/framework stage pinDigest -> 0283fb0
quay.io/kairos/framework stage pinDigest -> b4c475b
quay.io/kairos/framework final pinDigest -> b4c475b
quay.io/kairos/framework final pinDigest -> e4d8fac
quay.io/kairos/osbuilder-tools final pinDigest -> 6ad4d6c
quay.io/kairos/osbuilder-tools stage pinDigest -> 6ad4d6c
rockylinux stage pinDigest -> d7be1c0
ubuntu stage pinDigest -> 340d9b0
ubuntu final pinDigest -> 0b89735
ubuntu final pinDigest -> 340d9b0
ubuntu stage pinDigest -> 0b89735

Configuration

📅 Schedule: Branch creation - "after 11pm every weekday,before 7am every weekday,every weekend" in timezone Europe/Brussels, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

Copy link
Member

@mauromorales mauromorales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one is problematic when building multi-arch, I think it's better if we don't do

@renovate renovate bot force-pushed the renovate/pin-dependencies branch 3 times, most recently from ea94a70 to d3f8b3f Compare July 2, 2024 03:16
@Itxaka
Copy link
Member

Itxaka commented Jul 2, 2024

cc @mauromorales are we sure about this? becuase now it seems to run as expected??? no problems building arm? should we try it after cutting 3.1.x ?

@mauromorales
Copy link
Member

@Itxaka for me it still breaks if I try to build the dockerfiles directly

@mauromorales
Copy link
Member

how are you using it? maybe we are doing something different?

@renovate renovate bot force-pushed the renovate/pin-dependencies branch from d3f8b3f to 133e3fa Compare July 2, 2024 16:29
@renovate renovate bot force-pushed the renovate/pin-dependencies branch from 133e3fa to 3c23e13 Compare July 4, 2024 09:54
@Itxaka
Copy link
Member

Itxaka commented Jul 4, 2024

I just do a docker build --platform=WHATEVER but it seems to stick, so I have to alternate between amd64 and arm64 manually, otherwise it will remember the latest platform used. But that also happens with normal containers:

$ docker run --platform=arm64 -it --rm opensuse/leap:15.6               
:/ # uname -a
Linux d6eca054f9bb 6.9.7-arch1-1 #1 SMP PREEMPT_DYNAMIC Fri, 28 Jun 2024 04:32:50 +0000 aarch64 aarch64 aarch64 GNU/Linux
:/ # exit
$ docker run -it --rm opensuse/leap:15.6
WARNING: The requested image's platform (linux/arm64) does not match the detected host platform (linux/amd64/v3) and no specific platform was requested
:/ # uname -a
Linux 220699d426d4 6.9.7-arch1-1 #1 SMP PREEMPT_DYNAMIC Fri, 28 Jun 2024 04:32:50 +0000 aarch64 aarch64 aarch64 GNU/Linux
:/ # exit
$ docker run -it --platform=amd64 --rm opensuse/leap:15.6
Unable to find image 'opensuse/leap:15.6' locally
15.6: Pulling from opensuse/leap
Digest: sha256:2f0d8bb33b4d6869bbcf65ef925f9da8a863e75268da66943a3fa8a721347869
Status: Downloaded newer image for opensuse/leap:15.6
37a6b1f94be4:/ # uname -a
Linux 37a6b1f94be4 6.9.7-arch1-1 #1 SMP PREEMPT_DYNAMIC Fri, 28 Jun 2024 04:32:50 +0000 x86_64 x86_64 x86_64 GNU/Linux
37a6b1f94be4:/ # exit
$ docker run -it --rm opensuse/leap:15.6 
0fb840cfc829:/ # exit

@Itxaka
Copy link
Member

Itxaka commented Jul 4, 2024

ahh I see the problem is the digest that tis the same for multiplat images.

Already reported upstream it seems, no workaround: moby/moby#43188

So it would work on earthly becuase of its nature and on CI because everything is ephemeral, but not locally as the digests would match

Good catch @mauromorales , lets close this then!

@Itxaka Itxaka closed this Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants