Add Ubuntu 24.04 to pipelines #2447
Conversation
mauromorales
force-pushed
the
2445-bump-ubuntu
branch
2 times, most recently
from
8c9a900 to
4743e60
Compare
| "baseImage": "ubuntu:24.04", | ||
| "arch": "arm64", | ||
| "worker": "ubuntu-latest" | ||
| }, |
There was a problem hiding this comment.
not adding rpi because of the kernel issue
| @@ -10,24 +10,24 @@ concurrency: | |||
| env: | |||
| FORCE_COLOR: 1 | |||
| jobs: | |||
| core: | |||
| core-ubuntu-22-lts: | |||
There was a problem hiding this comment.
for PRs I'm removing 23.10 completely because it will be tested on master
mauromorales
force-pushed
the
2445-bump-ubuntu
branch
from
4743e60 to
93194f6
Compare
| @@ -38,7 +38,7 @@ jobs: | |||
| sudo apt update && sudo apt install -y jq | |||
| - id: set-matrix | |||
| run: | | |||
| content=`cat ./.github/flavors.json | jq -r 'map(select(.arch == "amd64" and .variant == "core" and (.flavor == "fedora" or (.flavor == "ubuntu" and .flavorRelease == "23.10"))))'` | |||
| content=`cat ./.github/flavors.json | jq -r 'map(select(.arch == "amd64" and .variant == "core" and (.flavor == "fedora" or (.flavor == "ubuntu" and (.flavorRelease == "23.10" or .flavorRelease == "24.04")))))'` | |||
There was a problem hiding this comment.
I thought it might be good to also produce the 24.04 uki in case it's helpful to test that one too
mauromorales
force-pushed
the
2445-bump-ubuntu
branch
2 times, most recently
from
54b014d to
23c35a4
Compare
mauromorales
force-pushed
the
2445-bump-ubuntu
branch
2 times, most recently
from
2ee7eda to
d9e3d9e
Compare
|
Unfortunately this is not working with UKI: Apparently the binary We need to extend immucore to check which of the two binaries exist before we can continue here |
mauromorales
force-pushed
the
2445-bump-ubuntu
branch
from
06d5ce8 to
2a6793d
Compare
|
This is now working as expected but will put as blocked because we need to revert immucore changes temporarily |
|
@mauromorales I ran into the same issue today. Can you let me know when I can rebuild a Kairos image with the immucore changes implemented? |
|
@kreeuwijk will do ... in the meantime, if you're building your image with earthly, you should be able to pass the |
|
I was able to build a Kairos image with earthly. I did need to use a custom base image instead of to ensure the expected content is present. |
|
ah yes sorry, I forgot to mention you'd need to be on this branch but nice to see that the factory works as expected 🙌 |
mauromorales
force-pushed
the
2445-bump-ubuntu
branch
from
2a6793d to
8cb2860
Compare
|
not blocked any more, rebased from master and if tests are green, it's good to merge |
|
If #2291 gets merged before this one, we need to also add 24.04 in those new tests |
|
master is still pointing to a framework image with immucore 0.1.24 so still blocked |
mauromorales
force-pushed
the
2445-bump-ubuntu
branch
from
8cb2860 to
d6e01c6
Compare
And introduce reusable test for uki Signed-off-by: Mauro Morales <[email protected]>
Signed-off-by: Mauro Morales <[email protected]>
Signed-off-by: Mauro Morales <[email protected]>
Signed-off-by: Mauro Morales <[email protected]>
mauromorales
force-pushed
the
2445-bump-ubuntu
branch
from
d6e01c6 to
21b4cf8
Compare
|
looks good now, merging |
|
@kreeuwijk this has been merged and you can also consume the following artifact if it helps |
* Add Ubuntu 24.04 to pipelines And introduce reusable test for uki Signed-off-by: Mauro Morales <[email protected]> * Introduce new kernel Signed-off-by: Mauro Morales <[email protected]> * Add rpi4 Signed-off-by: Mauro Morales <[email protected]> * Adapt new custom partitioning test Signed-off-by: Mauro Morales <[email protected]> --------- Signed-off-by: Mauro Morales <[email protected]>
And introduce reusable test for uki
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):relates to #2138