[POC] Use a single network dracut package #1900
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Itxaka <[email protected]>
|
Nice! I guess this has to be move to the packages repo to be properly used right? |
Yep! Mainly here to test if it worked as expected! |
|
ok, seems that this had a good reception, will create a new package with it and move kairos to use it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POC of using a single network package that loads and installs the needed module in dracut so we dont have to choose between network and network-legacy and can keep it down to just one package.
This checks the dracut module to check if it exists and if it does, it sets it as dependency of the kairos-network dracut module, so it includes the proper one on each.
This is also extensible, so we can include connman, NetworkManager and systemd-networkd at any moment.
This can be provided via luet packages and the other 2 network packages dropped altogether, so we can have just one package for all flavors, no need to manually choose and/or keep it.
Could even be included as part of the immucore dracut package so immucore deals with this directly and selects the proper network stuff, but that makes it dependent on immucore releases.
Tested with:
All of them booted with
rd.neednet=1andrd.break=pre-pivotto test inside initramfs. In all cases, the eth0 had an ip and external network connectivity.