Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single magical bootargs #1824

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Single magical bootargs #1824

merged 1 commit into from
Sep 22, 2023

Conversation

Itxaka
Copy link
Member

@Itxaka Itxaka commented Sep 15, 2023

What this PR does / why we need it:

Merge all bootargs from all flavors into a single bootargs that can infer the actual flavor and set the proper cmdline for each one.

The idea is to merge this, test this and then move the bootargs into the package with the yip configs and such so its installed on the framework directly and shipped as the default bootargs thus removing it from here.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@Itxaka
Copy link
Member Author

Itxaka commented Sep 15, 2023

ubuntu:

kairos@localhost:~$ cat /proc/cmdline 
BOOT_IMAGE=(loop0)/boot/vmlinuz console=tty1 net.ifnames=1 rd.cos.oemlabel=COS_OEM rd.cos.oemtimeout=10 panic=5 rd.emergency=reboot rd.shell=0 systemd.crash_reboot=yes root=LABEL=COS_ACTIVE cos-img/filename=/cOS/active.img security=selinux selinux=1 console=ttyS0 rd.emergency=reboot rd.shell=0 panic=5 systemd.crash_reboot systemd.crash_shell=0
kairos@localhost:~$ cat /etc/os-release 
PRETTY_NAME="Ubuntu 23.04"
NAME="Ubuntu"
VERSION_ID="23.04"
VERSION="23.04 (Lunar Lobster)"
VERSION_CODENAME=lunar
ID=ubuntu
ID_LIKE=debian
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
UBUNTU_CODENAME=lunar
LOGO=ubuntu-logo
KAIROS_NAME="kairos-core-ubuntu"
KAIROS_VERSION="v2.4.0-5-gd252ef2"
KAIROS_ID="kairos"
KAIROS_ID_LIKE="kairos-core-ubuntu"
KAIROS_VERSION_ID="v2.4.0-5-gd252ef2"
KAIROS_PRETTY_NAME="kairos-core-ubuntu v2.4.0-5-gd252ef2"
KAIROS_BUG_REPORT_URL="https://github.com/kairos-io/kairos/issues"
KAIROS_HOME_URL="https://github.com/kairos-io/kairos"
KAIROS_IMAGE_REPO="quay.io/kairos/core-ubuntu"
KAIROS_IMAGE_LABEL=""
KAIROS_GITHUB_REPO="kairos-io/kairos"
KAIROS_VARIANT="core"
KAIROS_FLAVOR="ubuntu"

@Itxaka Itxaka marked this pull request as ready for review September 18, 2023 08:32
@Itxaka Itxaka requested a review from a team September 18, 2023 08:33
jimmykarily
jimmykarily previously approved these changes Sep 20, 2023
@Itxaka Itxaka enabled auto-merge (squash) September 21, 2023 16:14
@Itxaka Itxaka merged commit 9a3f305 into kairos-io:master Sep 22, 2023
21 checks passed
@mudler
Copy link
Member

mudler commented Oct 16, 2023

given the large amount of logical changes in the grub configuration probably this should have been going into a 2.x branch rather than a patch release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants