🐛 Fix bootargs matcher for rpi #1810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was matching before on ubuntu flavours and copying the debian one all the time in rpi stuff Also adds a check to copy it only if its not there already so we dont touch it on other artifacts Signed-off-by: Itxaka <[email protected]>
Itxaka
commented
Sep 12, 2023
| COPY ./images/alpine/bootargs.cfg /framework/etc/cos/bootargs.cfg | ||
| ELSE IF [[ "$FLAVOR" = "ubuntu-20-lts-arm-nvidia-jetson-agx-orin" ]] | ||
| COPY ./images/nvidia/bootargs.cfg /framework/etc/cos/bootargs.cfg | ||
| ELSE IF [[ "$FLAVOR" =~ "ubuntu" ]] && [[ ! "$FLAVOR" =~ -rpi$ ]] |
There was a problem hiding this comment.
This is the main change, checking negative regex on rpi so we dont enter here if its ubuntu-*-rpi
jimmykarily
approved these changes
Sep 12, 2023
|
not waiting for CI as it wont fail or anything |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was matching before on ubuntu flavours and copying the debian one all the time in rpi stuff
Also adds a check to copy it only if its not there already so we dont touch it on other artifacts
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #