Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Run validations before customizing a RPi image #1420

Closed
mauromorales opened this issue May 16, 2023 · 3 comments · Fixed by kairos-io/kairos-docs#28
Closed

✨ Run validations before customizing a RPi image #1420

mauromorales opened this issue May 16, 2023 · 3 comments · Fixed by kairos-io/kairos-docs#28
Assignees
Labels
enhancement New feature or request papercut You wont die from this, but its very annoying

Comments

@mauromorales
Copy link
Member

Is your feature request related to a problem? Please describe.

When customizing a RPi image, if you made a mistake on your cloud config, you will only find out after building and copying to the SD card.

Describe the solution you'd like

Validations would run at the beginning of the process

Describe alternatives you've considered

n/a

Additional context

n/a

@mauromorales mauromorales added enhancement New feature or request papercut You wont die from this, but its very annoying labels May 16, 2023
@mauromorales mauromorales changed the title ❇️ Run validations before customizing a RPi image ✨ Run validations before customizing a RPi image May 16, 2023
@jimmykarily
Copy link
Contributor

We could add the validate command to the kairosctl so that the users can at least run it manually. Doing that automatically when people use the osbuilder flow would also be good.

@jimmykarily jimmykarily moved this from Todo 🖊 to Under review 🔍 in 🧙Issue tracking board May 22, 2023
@jimmykarily jimmykarily moved this from Under review 🔍 to Todo 🖊 in 🧙Issue tracking board May 22, 2023
@mudler
Copy link
Member

mudler commented May 22, 2023

That looks really tight to #958

@mauromorales
Copy link
Member Author

I decided to add the command to kairosctl because I think it's going to be needed there anyway and updated the documentation. It's not solving #958 but I think that one will need a bit more thought

@mauromorales mauromorales moved this from In Progress 🏃 to Under review 🔍 in 🧙Issue tracking board May 26, 2023
@github-project-automation github-project-automation bot moved this from Under review 🔍 to Done ✅ in 🧙Issue tracking board May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request papercut You wont die from this, but its very annoying
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants