Document validation of cloud config before customizing an RPi image #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mauro Morales <[email protected]>
✅ Deploy Preview for kairos-io ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
mauromorales
changed the title
jimmykarily
reviewed
May 26, 2023
| docker pull $IMAGE | ||
| # Validate the configuration file | ||
| kairosctl validate cloud-config.yaml | ||
| # Customize it |
There was a problem hiding this comment.
Customize what? If it's about the configuration file, it should be customized before validation (so that the user validates the final one). If it's about the image being created, maybe something like build the custom image might be clearer.
jimmykarily
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes kairos-io/kairos#1420