Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add assesment docs #323
base: main
Are you sure you want to change the base?
Add assesment docs #323
Changes from 1 commit
01b7c27
d165e29
3caf569
618a8d0
1e392ce
68e0e49
1c9110d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By reading it entirely something is not really clear to me: here we say that the example is on how to enable the automatic boot assessment, but later we talk about marking an arbitrary service failure impacting the boot assessment - I think we should be explicit here in answering the following questions:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we currently dont have any assesment strategy...yet.
The idea was to write the docs first and then start enabling it ourselves, plus adding e2e tests for it.
Current boot assessment is set as the default, i.e. if multi-user.target is reached, then it considers the system as good and marks it as such.
But I get what you mean, I will redo this to extend to introduce first the current states of assesment on kairos and then keep this as how can be extended to support more things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Expanded!