Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create docs page #264

Merged
merged 9 commits into from
Sep 18, 2024
Merged

Conversation

jimmykarily
Copy link
Contributor

@jimmykarily jimmykarily self-assigned this Sep 17, 2024
Copy link

netlify bot commented Sep 17, 2024

Deploy Preview for kairos-io ready!

Name Link
🔨 Latest commit 6b6b3c7
🔍 Latest deploy log https://app.netlify.com/sites/kairos-io/deploys/66ea9a8446d07b00088bb693
😎 Deploy Preview https://deploy-preview-264--kairos-io.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jimmykarily jimmykarily force-pushed the 2798-document-transition-image-evaluation branch from f4c6857 to 8fe1aaa Compare September 17, 2024 13:15
Signed-off-by: Dimitris Karakasilis <[email protected]>
Signed-off-by: Dimitris Karakasilis <[email protected]>
Signed-off-by: Dimitris Karakasilis <[email protected]>
Signed-off-by: Dimitris Karakasilis <[email protected]>
@jimmykarily jimmykarily force-pushed the 2798-document-transition-image-evaluation branch from 8fe1aaa to e6f6782 Compare September 18, 2024 08:23
Signed-off-by: Dimitris Karakasilis <[email protected]>
@jimmykarily
Copy link
Contributor Author

This PR addresses most of the items in the ticket description but I'm not sure what was meant by "Check image integrity". I couldn't find any other mechanisms we have in place. If I missed something let me know and I will add it.

@jimmykarily jimmykarily marked this pull request as ready for review September 18, 2024 08:56
@jimmykarily jimmykarily requested a review from a team September 18, 2024 08:56
Signed-off-by: Dimitris Karakasilis <[email protected]>
@jimmykarily jimmykarily force-pushed the 2798-document-transition-image-evaluation branch from c3da260 to 4570355 Compare September 18, 2024 08:59
Copy link
Member

@Itxaka Itxaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. I wonder if we should add the same parameters to the trusted boot install defaults to have automatic reboots on kernel and systemd crashes...

@jimmykarily
Copy link
Contributor Author

looks good. I wonder if we should add the same parameters to the trusted boot install defaults to have automatic reboots on kernel and systemd crashes...

We should. But this is the "documentation" ticket. I'm only documenting what we already have :D. I will create a ticket for this.

@jimmykarily
Copy link
Contributor Author

looks good. I wonder if we should add the same parameters to the trusted boot install defaults to have automatic reboots on kernel and systemd crashes...

We should. But this is the "documentation" ticket. I'm only documenting what we already have :D. I will create a ticket for this.

kairos-io/kairos#2869

Signed-off-by: Dimitris Karakasilis <[email protected]>
Signed-off-by: Dimitris Karakasilis <[email protected]>
@jimmykarily jimmykarily merged commit 03846dd into main Sep 18, 2024
1 check passed
@jimmykarily jimmykarily deleted the 2798-document-transition-image-evaluation branch September 18, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

feat: document how kairos evaluates a transition image
2 participants