Expand DeployImage to be more flexible #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Itxaka
force-pushed
the
expand_DeployImage
branch
from
28894b5 to
5a28754
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #635 +/- ##
=======================================
Coverage 48.09% 48.10%
=======================================
Files 48 48
Lines 6148 6153 +5
=======================================
+ Hits 2957 2960 +3
- Misses 2910 2912 +2
Partials 281 281 ☔ View full report in Codecov by Sentry. |
Itxaka
force-pushed
the
expand_DeployImage
branch
from
fdcc746 to
5a28754
Compare
jimmykarily
reviewed
Dec 17, 2024
Usually we create the system dirs in images by default, but that means that we cannot reuse the DeployImage for deploying random non-system images. This fixes it by adding an extra param to create the dir structure in the created image Signed-off-by: Itxaka <[email protected]>
Itxaka
force-pushed
the
expand_DeployImage
branch
from
5a28754 to
d7adfcd
Compare
jimmykarily
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usually we create the system dirs in images by default, but that means that we cannot reuse the DeployImage for deploying random non-system images.
This fixes it by adding an extra param to create the dir structure in the created image