Fix boot selection on uki #624
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems like systemd-boot identifies entries by the ID whcih doesnt show anywhere, and that Id is the entry conf name minus the boot assesment Signed-off-by: Itxaka <[email protected]>
|
this shit is lying to me, it doesnt seem to do what it says in there, even if I set passive.conf as the entry, it will NOT select the passive....I dont get it. |
| @@ -133,13 +133,9 @@ func selectBootEntrySystemd(cfg *config.Config, entry string) error { | |||
| if err != nil { | |||
| return err | |||
| } | |||
| assessment, err := utils.ReadAssessmentFromEntry(cfg.Fs, bootFileName, cfg.Logger) | |||
There was a problem hiding this comment.
I think this function is only used here and the tests so maybe it can be removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like systemd-boot identifies entries by the ID which doesnt show anywhere, and that Id is the entry conf name minus the boot assessment
This means we can drop the boot assessment part from the loader.conf default entry selection