Add sort-key during install based on the entry name #609
Conversation
Signed-off-by: Itxaka <[email protected]>
Itxaka
force-pushed
the
add_sort_key_on_install
branch
from
79fcdf6 to
9f62e90
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Itxaka <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #609 +/- ##
==========================================
- Coverage 48.47% 48.09% -0.38%
==========================================
Files 48 48
Lines 6100 6148 +48
==========================================
Hits 2957 2957
- Misses 2862 2910 +48
Partials 281 281 ☔ View full report in Codecov by Sentry. |
| var sortKey string | ||
| // If we have 2 different files that start with active, like with the extra-cmdline, how do we set this? | ||
| // Ideally if they both have the same sort key, they will be sorted by name so the single one will be first | ||
| // and the extra-cmdline will be second. This is the best we can do currently without making this a mess |
There was a problem hiding this comment.
If the extra was meant to be the "default", it would not be set as extra cmdline. I think extra cmdlines were always meant to be alternative boot entries, not part of the "active", "passive", "recovery" dance.
There was a problem hiding this comment.
Having said that, if "active" fails to boot, I don't think we would want to try "active_myops" next, would we? The next thing we would want to try would be "passive". Unless I'm missing some user flow.
There was a problem hiding this comment.
Im not sure, maybe active and active_debug should be tried one after the other?
Thats why this has a big explanation, I guess we can add this then move into a more detailed thing or explain it better?
In any case, this is just the first implementation, usually this would not matter much (the order) as we select explicit entries, so this will come later down the line when people start implementing assessment and such?
Fixes kairos-io/kairos#3040