Drop those stupid github and vfs deps bumps #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move to latest version of those, hope we dont get more automated renovate PRs for them Signed-off-by: Itxaka <[email protected]>
There was a problem hiding this comment.
Copilot reviewed 6 out of 21 changed files in this pull request and generated no suggestions.
Files not reviewed (15)
- go.mod: Language not supported
- pkg/action/reset_test.go: Evaluated as low risk
- internal/agent/install_test.go: Evaluated as low risk
- pkg/cloudinit/cloudinit.go: Evaluated as low risk
- pkg/action/upgrade_test.go: Evaluated as low risk
- pkg/config/config.go: Evaluated as low risk
- pkg/elemental/elemental_test.go: Evaluated as low risk
- pkg/utils/common.go: Evaluated as low risk
- pkg/config/config_test.go: Evaluated as low risk
- pkg/github/releases.go: Evaluated as low risk
- pkg/utils/fs/fs.go: Evaluated as low risk
- pkg/utils/runstage_test.go: Evaluated as low risk
- pkg/config/spec_test.go: Evaluated as low risk
- pkg/utils/utils_test.go: Evaluated as low risk
- pkg/action/bootentries_test.go: Evaluated as low risk
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #591 +/- ##
==========================================
- Coverage 48.29% 48.24% -0.05%
==========================================
Files 48 48
Lines 6017 6017
==========================================
- Hits 2906 2903 -3
- Misses 2835 2837 +2
- Partials 276 277 +1 ☔ View full report in Codecov by Sentry. |
jimmykarily
reviewed
Nov 6, 2024
| @@ -193,6 +190,7 @@ require ( | |||
| github.com/tklauser/go-sysconf v0.3.12 // indirect | |||
| github.com/tklauser/numcpus v0.6.1 // indirect | |||
| github.com/tredoe/osutil v1.5.0 // indirect | |||
| github.com/twpayne/go-vfs/v4 v4.3.0 // indirect | |||
There was a problem hiding this comment.
shouldn't this be v5? That's what you bumped to in the code.
There was a problem hiding this comment.
indirect, so it measn something in the deps is bringing it, but IIRC the indirect deps are not bumped by renovate directly
jimmykarily
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move to latest version of those, hope we dont get more automated renovate PRs for them