Respect user defined/default sizes on upgrade #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Copilot
AI
left a comment
Copilot
AI
left a comment
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 suggestion.
Comments skipped due to low confidence (1)
pkg/config/spec.go:2
- The error returned by 'runner.Run' is being ignored. Consider handling the error to ensure any issues are properly logged or managed.
out, _ := runner.Run("cat", "/proc/cmdline")
Itxaka
force-pushed
the
respect_user_size
branch
from
a69eecf to
f3e44c9
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Itxaka
force-pushed
the
respect_user_size
branch
from
f3e44c9 to
a3fbb50
Compare
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.
Comments skipped due to low confidence (2)
pkg/config/spec.go:432
- The units for size should be consistent. Ensure that both sizes are represented in the same unit (MB or Mb).
cfg.Logger.Debugf("Calculated size (%dMB) is less than specified/default size (%dMB)", size, originalSize)
pkg/config/spec.go:431
- There is a potential type mismatch between
originalSize(uint) andsize(int64). Consider using the same type for both variables to avoid unexpected behavior.
if uint(size) < originalSize {
jimmykarily
approved these changes
Nov 5, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #587 +/- ##
==========================================
+ Coverage 48.23% 48.34% +0.11%
==========================================
Files 48 48
Lines 6002 6017 +15
==========================================
+ Hits 2895 2909 +14
- Misses 2831 2833 +2
+ Partials 276 275 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Copilot reviewed 5 out of 7 changed files in this pull request and generated no suggestions.
Files not reviewed (2)
- pkg/config/config_test.go: Evaluated as low risk
- pkg/action/upgrade_test.go: Evaluated as low risk
We were ignoring if the user set any values in there and just overwriting it with our calculated size Signed-off-by: Itxaka <[email protected]>
Itxaka
force-pushed
the
respect_user_size
branch
from
4a21f59 to
c8bf3f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were ignoring if the user set any values in there and just overwriting it with our calculated size
Fixes kairos-io/kairos#2985