Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run osv scanner on PRs #392

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Run osv scanner on PRs #392

merged 1 commit into from
Jul 2, 2024

Conversation

mauromorales
Copy link
Member

@mauromorales mauromorales commented Jul 1, 2024

@kairos-io/maintainers for this PR, the main issue atm is Go 1.19, so how do you all feel about merging it even if it will be red all the time? Or would you prefer that we first deal with kairos-io/kairos#2670 ? And the same question about the rest of our projects in Go

👍 Let's merge, despite it being red until we bump Go
👎 No thank you, I like my pipelines green
💬 suggest something else

Signed-off-by: Mauro Morales <[email protected]>
@mauromorales mauromorales changed the title [Run osv scanner on PRs [WIP] Run osv scanner on PRs Jul 1, 2024
@mauromorales mauromorales marked this pull request as draft July 1, 2024 14:48
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.20%. Comparing base (a3fc161) to head (a8eda7f).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #392   +/-   ##
=======================================
  Coverage   52.20%   52.20%           
=======================================
  Files          52       52           
  Lines        4902     4902           
=======================================
  Hits         2559     2559           
  Misses       2060     2060           
  Partials      283      283           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mauromorales mauromorales changed the title [WIP] Run osv scanner on PRs Run osv scanner on PRs Jul 2, 2024
@mauromorales mauromorales marked this pull request as ready for review July 2, 2024 07:33
@mauromorales mauromorales self-assigned this Jul 2, 2024
@mauromorales mauromorales merged commit fb5a0e3 into main Jul 2, 2024
17 of 18 checks passed
@mauromorales mauromorales deleted the add-osv branch July 2, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants