Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump kcrypt and adapt hooks #385

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Bump kcrypt and adapt hooks #385

merged 2 commits into from
Jun 20, 2024

Conversation

Itxaka
Copy link
Member

@Itxaka Itxaka commented Jun 19, 2024

Now we can pass the logger directly so we see the logs as usual Also set systemd debug mode before running the commands so we can see the debug output in case of failrue

@Itxaka Itxaka requested a review from a team June 19, 2024 14:51
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 52.20%. Comparing base (569c131) to head (3489e0a).
Report is 5 commits behind head on main.

Files Patch % Lines
internal/agent/hooks/kcrypt_uki.go 0.00% 7 Missing ⚠️
internal/agent/hooks/kcrypt.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #385      +/-   ##
==========================================
- Coverage   55.94%   52.20%   -3.75%     
==========================================
  Files          48       52       +4     
  Lines        4549     4902     +353     
==========================================
+ Hits         2545     2559      +14     
- Misses       1724     2060     +336     
- Partials      280      283       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Now we can pass the logger directly so we see the logs as usual
Also set systemd debug mode before running the commands so we can see
the debug output in case of failrue

Signed-off-by: Itxaka <[email protected]>
go.sum Outdated
@@ -321,6 +321,10 @@ github.com/kairos-io/kairos-sdk v0.2.3 h1:QXqjVtOm5Ki4N1diI+H6ydrStFhDHDbDkK25HJ
github.com/kairos-io/kairos-sdk v0.2.3/go.mod h1:wbQNMckCGT/kKd+tqhAZo4thDBPWxpcKaymWJmRqSUg=
github.com/kairos-io/kcrypt v0.11.2 h1:qu00WGDKvOn6tm9xaWho3RRpo0iRQBzZa9M/hnXhLbs=
github.com/kairos-io/kcrypt v0.11.2/go.mod h1:znIdTYzsTtePMDA2v5bDJeikqxIb0W6YJMH77TU2Phs=
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these need go mod tidy to go away?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have given up trying to understand go mod whatever. there is no logic to it

Signed-off-by: Itxaka <[email protected]>
@Itxaka
Copy link
Member Author

Itxaka commented Jun 20, 2024

To test the if luks1 can be unlocked with newer kcrypt version:

So basically the luks version does not affect the unlocking.

To test the new luks2 version by default:

  • Built a new image with kairos-agent pointing to this branch
earthly +iso \
            --FLAVOR=ubuntu \
            --FLAVOR_RELEASE=24.04 \
            --FAMILY=ubuntu \
            --MODEL=generic \
            --VARIANT=core \
            --BASE_IMAGE=ubuntu:24.04 --KAIROS_AGENT_DEV_BRANCH=bump_kcrypt2
  • Installed the iso with offline encryption
  • rebooted to active and confirmed that disk is encrypted and unlocked correctly
  • confirmed the luks header
    image
  • confirmed that immucore+agent had the proper versions of kcrypt

So basically it should not affect anything to change the default to luks2

@Itxaka Itxaka merged commit aebc8f6 into main Jun 20, 2024
12 of 13 checks passed
@Itxaka Itxaka deleted the bump_kcrypt2 branch June 20, 2024 09:19
github-actions bot referenced this pull request in kairos-io/provider-kairos Jun 26, 2024
…2.0 (#584)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[github.com/kairos-io/kairos-agent/v2](https://togithub.com/kairos-io/kairos-agent)
| `v2.11.0` -> `v2.12.0` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fkairos-io%2fkairos-agent%2fv2/v2.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fkairos-io%2fkairos-agent%2fv2/v2.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fkairos-io%2fkairos-agent%2fv2/v2.11.0/v2.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fkairos-io%2fkairos-agent%2fv2/v2.11.0/v2.12.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>kairos-io/kairos-agent
(github.com/kairos-io/kairos-agent/v2)</summary>

###
[`v2.12.0`](https://togithub.com/kairos-io/kairos-agent/releases/tag/v2.12.0)

[Compare
Source](https://togithub.com/kairos-io/kairos-agent/compare/v2.11.0...v2.12.0)

#### What's Changed

- Update module github.com/google/go-containerregistry to v0.19.2 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/kairos-io/kairos-agent/pull/380](https://togithub.com/kairos-io/kairos-agent/pull/380)
- Update module github.com/google/go-github/v40 to v62 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/kairos-io/kairos-agent/pull/381](https://togithub.com/kairos-io/kairos-agent/pull/381)
- Skip dirs in copyArtifactSetRole and replace only basename by
[@&#8203;jimmykarily](https://togithub.com/jimmykarily) in
[https://github.com/kairos-io/kairos-agent/pull/382](https://togithub.com/kairos-io/kairos-agent/pull/382)
- Update dependency alpinejs to v3.14.1 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/kairos-io/kairos-agent/pull/383](https://togithub.com/kairos-io/kairos-agent/pull/383)
- Update dependency cypress to v13.12.0 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/kairos-io/kairos-agent/pull/384](https://togithub.com/kairos-io/kairos-agent/pull/384)
- Bump kcrypt and adapt hooks by
[@&#8203;Itxaka](https://togithub.com/Itxaka) in
[https://github.com/kairos-io/kairos-agent/pull/385](https://togithub.com/kairos-io/kairos-agent/pull/385)
- Update module github.com/google/go-github/v40 to v62 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/kairos-io/kairos-agent/pull/386](https://togithub.com/kairos-io/kairos-agent/pull/386)
- Update module github.com/google/go-github/v40 to v62 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/kairos-io/kairos-agent/pull/387](https://togithub.com/kairos-io/kairos-agent/pull/387)
- Bump yip to v1.9.0 by
[@&#8203;jimmykarily](https://togithub.com/jimmykarily) in
[https://github.com/kairos-io/kairos-agent/pull/388](https://togithub.com/kairos-io/kairos-agent/pull/388)

**Full Changelog**:
kairos-io/kairos-agent@v2.11.0...v2.12.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 11pm every weekday,before 7am
every weekday,every weekend" in timezone Europe/Brussels, Automerge - At
any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/kairos-io/provider-kairos).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MTMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjQxMy4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants