Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy any found sysextensions into active+passive efi dir #372

Merged
merged 5 commits into from
Jun 7, 2024

Conversation

Itxaka
Copy link
Member

@Itxaka Itxaka commented Jun 6, 2024

No description provided.

@Itxaka Itxaka requested a review from a team June 6, 2024 12:28
Copy link

codecov bot commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 72.54902% with 14 lines in your changes missing coverage. Please review.

Project coverage is 56.03%. Comparing base (9b7d21e) to head (b53c71f).
Report is 2 commits behind head on main.

Files Patch % Lines
internal/agent/hooks/sysext.go 72.54% 11 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #372      +/-   ##
==========================================
- Coverage   59.07%   56.03%   -3.04%     
==========================================
  Files          39       48       +9     
  Lines        4242     4538     +296     
==========================================
+ Hits         2506     2543      +37     
- Misses       1460     1716     +256     
- Partials      276      279       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Itxaka <[email protected]>
@jimmykarily
Copy link
Contributor

What I see looks good but can this be merged as it is? I mean, I guess more things are missing to implement the signed extensions feature but this at least won't break anything, right?

@jimmykarily
Copy link
Contributor

Oh, also it will need testing but I guess we can go with and e2e test in kairos.

@Itxaka
Copy link
Member Author

Itxaka commented Jun 7, 2024

Oh, also it will need testing but I guess we can go with and e2e test in kairos.

I think it should be ok to test it here as part of the agent tests :D

@Itxaka Itxaka marked this pull request as ready for review June 7, 2024 14:07
@Itxaka Itxaka merged commit b176b47 into main Jun 7, 2024
12 of 13 checks passed
@Itxaka Itxaka deleted the sysext_support_uki branch June 7, 2024 14:45
github-actions bot referenced this pull request in kairos-io/provider-kairos Jun 13, 2024
…1.0 (#582)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[github.com/kairos-io/kairos-agent/v2](https://togithub.com/kairos-io/kairos-agent)
| `v2.10.7` -> `v2.11.0` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fkairos-io%2fkairos-agent%2fv2/v2.11.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fkairos-io%2fkairos-agent%2fv2/v2.11.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fkairos-io%2fkairos-agent%2fv2/v2.10.7/v2.11.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fkairos-io%2fkairos-agent%2fv2/v2.10.7/v2.11.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>kairos-io/kairos-agent
(github.com/kairos-io/kairos-agent/v2)</summary>

###
[`v2.11.0`](https://togithub.com/kairos-io/kairos-agent/releases/tag/v2.11.0)

[Compare
Source](https://togithub.com/kairos-io/kairos-agent/compare/v2.10.7...v2.11.0)

#### What's Changed

- Update module github.com/google/go-github/v40 to v62 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/kairos-io/kairos-agent/pull/370](https://togithub.com/kairos-io/kairos-agent/pull/370)
- Update module github.com/google/go-github/v40 to v62 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/kairos-io/kairos-agent/pull/373](https://togithub.com/kairos-io/kairos-agent/pull/373)
- Copy any found sysextensions into active+passive efi dir by
[@&#8203;Itxaka](https://togithub.com/Itxaka) in
[https://github.com/kairos-io/kairos-agent/pull/372](https://togithub.com/kairos-io/kairos-agent/pull/372)
- Update module github.com/mudler/yip to v1.8.0 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/kairos-io/kairos-agent/pull/374](https://togithub.com/kairos-io/kairos-agent/pull/374)
- Update module github.com/google/go-github/v40 to v62 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/kairos-io/kairos-agent/pull/375](https://togithub.com/kairos-io/kairos-agent/pull/375)
- Update module github.com/mudler/yip to v1.8.1 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/kairos-io/kairos-agent/pull/377](https://togithub.com/kairos-io/kairos-agent/pull/377)
- Update module github.com/google/go-github/v40 to v62 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/kairos-io/kairos-agent/pull/378](https://togithub.com/kairos-io/kairos-agent/pull/378)
- Ensure only numeric part of systemd version is converted to int by
[@&#8203;ZauberNerd](https://togithub.com/ZauberNerd) in
[https://github.com/kairos-io/kairos-agent/pull/362](https://togithub.com/kairos-io/kairos-agent/pull/362)

#### New Contributors

- [@&#8203;ZauberNerd](https://togithub.com/ZauberNerd) made their first
contribution in
[https://github.com/kairos-io/kairos-agent/pull/362](https://togithub.com/kairos-io/kairos-agent/pull/362)

**Full Changelog**:
kairos-io/kairos-agent@v2.10.7...v2.11.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 11pm every weekday,before 7am
every weekday,every weekend" in timezone Europe/Brussels, Automerge - At
any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/kairos-io/provider-kairos).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zOTMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjM5My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Implement measurement and policy generation/luks unlock of sysextensions for UKI
2 participants