-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing hooks to after install uki #307
Conversation
we were missing the bundle stuff, mounts (for custom mounts) and lifecycle Signed-off-by: Itxaka <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #307 +/- ##
=======================================
Coverage 59.07% 59.07%
=======================================
Files 39 39
Lines 4242 4242
=======================================
Hits 2506 2506
Misses 1460 1460
Partials 276 276 ☔ View full report in Codecov by Sentry. |
var AfterUkiInstall = []Interface{ | ||
&BundlePostInstall{}, | ||
&CustomMounts{}, | ||
&Lifecycle{}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about &CopyLogs{}
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In uki, the logs are copied as part of the encryption jhook as to not keeping closing and opening the encrypted devices several times.
(cherry picked from commit 1602276)
…0.0 (#545) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/kairos-io/kairos-agent/v2](https://togithub.com/kairos-io/kairos-agent) | `v2.9.1` -> `v2.10.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fkairos-io%2fkairos-agent%2fv2/v2.10.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fkairos-io%2fkairos-agent%2fv2/v2.10.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fkairos-io%2fkairos-agent%2fv2/v2.9.1/v2.10.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fkairos-io%2fkairos-agent%2fv2/v2.9.1/v2.10.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>kairos-io/kairos-agent (github.com/kairos-io/kairos-agent/v2)</summary> ### [`v2.10.0`](https://togithub.com/kairos-io/kairos-agent/releases/tag/v2.10.0) [Compare Source](https://togithub.com/kairos-io/kairos-agent/compare/v2.9.1...v2.10.0) #### What's Changed - Update module github.com/google/go-github/v40 to v61 by [@​renovate](https://togithub.com/renovate) in [https://github.com/kairos-io/kairos-agent/pull/298](https://togithub.com/kairos-io/kairos-agent/pull/298) - Update module github.com/twpayne/go-vfs/v4 to v5 by [@​renovate](https://togithub.com/renovate) in [https://github.com/kairos-io/kairos-agent/pull/299](https://togithub.com/kairos-io/kairos-agent/pull/299) - Update dependency cypress to v13.8.0 by [@​renovate](https://togithub.com/renovate) in [https://github.com/kairos-io/kairos-agent/pull/304](https://togithub.com/kairos-io/kairos-agent/pull/304) - Add missing hooks to after install uki by [@​Itxaka](https://togithub.com/Itxaka) in [https://github.com/kairos-io/kairos-agent/pull/307](https://togithub.com/kairos-io/kairos-agent/pull/307) - Update LICENSE by [@​mudler](https://togithub.com/mudler) in [https://github.com/kairos-io/kairos-agent/pull/308](https://togithub.com/kairos-io/kairos-agent/pull/308) - Centralize uki hooks for encryption reasons by [@​Itxaka](https://togithub.com/Itxaka) in [https://github.com/kairos-io/kairos-agent/pull/309](https://togithub.com/kairos-io/kairos-agent/pull/309) - Update dependency alpinejs to v3.13.10 by [@​renovate](https://togithub.com/renovate) in [https://github.com/kairos-io/kairos-agent/pull/310](https://togithub.com/kairos-io/kairos-agent/pull/310) - Update dependency cypress to v13.8.1 by [@​renovate](https://togithub.com/renovate) in [https://github.com/kairos-io/kairos-agent/pull/311](https://togithub.com/kairos-io/kairos-agent/pull/311) - Bump yip by [@​Itxaka](https://togithub.com/Itxaka) in [https://github.com/kairos-io/kairos-agent/pull/313](https://togithub.com/kairos-io/kairos-agent/pull/313) - Update module github.com/kairos-io/kcrypt to v0.10.1 by [@​renovate](https://togithub.com/renovate) in [https://github.com/kairos-io/kairos-agent/pull/306](https://togithub.com/kairos-io/kairos-agent/pull/306) **Full Changelog**: kairos-io/kairos-agent@v2.9.1...v2.10.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 11pm every weekday,before 7am every weekday,every weekend" in timezone Europe/Brussels, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/kairos-io/provider-kairos). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMjEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjMyMS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
we were missing the bundle stuff, mounts (for custom mounts) and lifecycle