Fix uki mode detection #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woops Signed-off-by: Itxaka <[email protected]>
so we dont fail to copy it properly. Its on the temp dir so it will be autoremoved by the system on reboot Signed-off-by: Itxaka <[email protected]>
Otherwise you end up with a broken half encrypted system with no OEM and cant troubleshoot it. Good for testing in devices that dont have TPM Signed-off-by: Itxaka <[email protected]>
Itxaka
commented
Jan 10, 2024
| if internalutils.UkiBootMode() == internalutils.UkiRemovableMedia { | ||
| return runInstallUki(c) | ||
| if internalutils.IsUki() { | ||
| c.Logger.Debugf("UKI mode: %s\n", internalutils.UkiBootMode()) |
There was a problem hiding this comment.
bit more of logging to be able to check what mode are we in, in case we broke it like I already did :D
Signed-off-by: Itxaka <[email protected]>
Itxaka
commented
Jan 10, 2024
| @@ -520,7 +520,7 @@ const ( | |||
| func UkiBootMode() state.Boot { | |||
| if IsUki() { | |||
| _, err := os.Stat("/run/cos/uki_boot_mode") | |||
| if err != nil { | |||
There was a problem hiding this comment.
wops, I broke it on the first iteration by mixing the check :D
jimmykarily
reviewed
Jan 10, 2024
jimmykarily
approved these changes
Jan 10, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #198 +/- ##
==========================================
- Coverage 58.22% 58.15% -0.08%
==========================================
Files 38 38
Lines 4778 4784 +6
==========================================
Hits 2782 2782
- Misses 1759 1765 +6
Partials 237 237 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.