-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the agent behave more like an agent #165
Conversation
This syncs with what we expect of the agent start as a service, something that runs in there and checks from time to time Signed-off-by: Itxaka <[email protected]>
Is this ok @mudler ? Before this, on alpine the service kept on restarting time and time again as it was kind of set as a service. This makes it behave more like a service, but Im not sure of the implications of really calling the bootstrap event over and over? Is this correct? Do we expect this behaviour to be like this? |
The thing with this is: kairos-agent is managed as a one off service on alpine currently exploring other ways of dealing with it. |
I think the real problem with this is: kairos agent behaves differently
|
default inittab:
Notice how the default runlevel has a but the status shows that kairos-agent under a provider is marked as starting forever:
|
well, adding a |
// capture ctrl+c and exit cleanly | ||
channel := make(chan os.Signal, 1) | ||
signal.Notify(channel, os.Interrupt) | ||
go func() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will spawn up a goroutine and grow indefinetly on each time Run
is called again
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a small nit but going in the good direction
This syncs with what we expect of the agent start as a service, something that runs in there and checks from time to time