Check root permissions in commands that need it

[jimmykarily]

Otherwise the error shown is not helpful (it fails too late with confusing errors).

[jimmykarily]

pull-image already had a check:

kairos-agent/main.go

Lines 576 to 578 in 274701a

	if os.Geteuid() != 0 {
	return fmt.Errorf("this command requires root privileges")
	}

The function I added is in a different package and not exported and I preferred not to re-use it. The alternative is to export it and use it in main.go too.

[Itxaka]

I would prefer this to be done on the main go inside the cmds with the Before: stanza, as otherwise a lot of work is done on the commands sometimes (like reading and preparing config and specs) for no reason and in fact that work could as well fail due to not enough permissions.

[jimmykarily]

I would prefer this to be done on the main go inside the cmds with the Before: stanza, as otherwise a lot of work is done on the commands sometimes (like reading and preparing config and specs) for no reason and in fact that work could as well fail due to not enough permissions.

good point, I'll move it there

[codecov]

Codecov Report

Merging #145 (b336e16) into main (417f8ce) will decrease coverage by 0.12%.
Report is 4 commits behind head on main.
The diff coverage is 43.33%.

@@            Coverage Diff             @@
##             main     #145      +/-   ##
==========================================
- Coverage   60.73%   60.62%   -0.12%     
==========================================
  Files          37       37              
  Lines        4452     4480      +28     
==========================================
+ Hits         2704     2716      +12     
- Misses       1521     1535      +14     
- Partials      227      229       +2     

Files Changed	Coverage Δ
internal/agent/agent.go	42.62% <ø> (ø)
internal/agent/install.go	5.55% <ø> (ø)
internal/agent/reset.go	0.00% <0.00%> (ø)
internal/agent/upgrade.go	0.00% <ø> (ø)
pkg/utils/grub.go	66.84% <42.85%> (-4.49%)	⬇️
pkg/http/client.go	85.71% <100.00%> (+0.42%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[Itxaka]

noice