Skip to content

Commit

Permalink
Merge branch 'develop' into bugs/missingInflateErr
Browse files Browse the repository at this point in the history
  • Loading branch information
hthetiot committed Jul 13, 2018
2 parents c5c2050 + a2b6da2 commit 462d9de
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 5 deletions.
10 changes: 6 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -123,10 +123,10 @@ point to understand the code.
To generate a code coverage report, run `npm test --coverage` (which runs very slowly, be patient).
Code coverage summary as of version 3.0.1:
```
Statements : 89.44% ( 1947/2177 )
Branches : 79.45% ( 816/1027 )
Functions : 89.06% ( 228/256 )
Lines : 89.53% ( 1941/2168 )
Statements : 89.47% ( 1980/2213 )
Branches : 79.03% ( 829/1049 )
Functions : 89.27% ( 233/261 )
Lines : 89.61% ( 1974/2203 )
```

There's a hosted version of the detailed (line-by-line) coverage report
Expand Down Expand Up @@ -160,6 +160,8 @@ The co-maintainer of the project is [Nick Hurley](https://github.com/todesschaf)

Code contributions are always welcome! People who contributed to `node-http2` and `http2.js` so far:

* [Kaazing](https://github.com/kaazing)
* [Nick Hurley](https://github.com/todesschaf)
* [Nick Hurley](https://github.com/todesschaf)
* [Mike Belshe](https://github.com/mbelshe)
* [Yoshihiro Iwanaga](https://github.com/iwanaga)
Expand Down
5 changes: 4 additions & 1 deletion test/http.js
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,10 @@ describe('http.js', function() {

it('does a request and gets a response with gzip encoding for response larger than MAX_PAYLOAD_SIZE', function (done) {
var path = '/x';
var message = generateRandAlphaNumStr(4096 * 10);
// TODO validate this test is not false positive or memory limit
// use larger than MAX_PAYLOAD_SIZE > 3 make that test fail
// Lines : 89.51% ( 1972/2203 ) vs Lines : 89.61% ( 1974/2203 )
var message = generateRandAlphaNumStr(4096 * 3);
var compressedMessage = pako.gzip(message);
compressedMessage = Buffer.from(compressedMessage.buffer);
var server = http2.createServer(serverOptions, function (request, response) {
Expand Down

0 comments on commit 462d9de

Please sign in to comment.