(issue#912, management) Fixed a memory leak by altering CollectOnlyMa… #841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nagementSessionStrategy.soSessionClosed to call doSessionClosedListeners on the sessionBean.
|
The PR looks good and seems to fix the problem. I didn't merge because I thought of adding an integration test. |
|
@danibusu Any ideas for how to do the integration test? I thought it might be possible to do one by using a test service so it can examine the MX bean on the session. I am not sure it's possible though. The unit test does confirm the code change. |
added 2 commits
January 5, 2017 10:54
Added integration test JmxSessionIT to check for MX session bean leak
…and verify there are none (otherwise the test was passing without the fix for kaazing#912).
|
Build failed twice in http.proxy service (ProxyServiceTest), filed as #846 |
danibusu
reviewed
Jan 6, 2017
|
|
||
| mbeanNames = mbeanServerConn.queryNames( | ||
| ObjectName.getInstance("*:serviceType=echo,name=sessions,*"), null); | ||
| for (ObjectName name : mbeanNames) { |
There was a problem hiding this comment.
Why use a for statement? The test will stop running after the first failure. Maybe check that the set size is zero?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nagementSessionStrategy.soSessionClosed to call doSessionClosedListeners on the sessionBean.
This should hopefully address the memory leak noted in ticket 912: the gateway is accumulating SessionMXBeanImpl instances.