Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Address linter issues #1014

Merged
merged 1 commit into from
Oct 10, 2024
Merged

chore: Address linter issues #1014

merged 1 commit into from
Oct 10, 2024

Conversation

mhutter
Copy link
Contributor

@mhutter mhutter commented Oct 9, 2024

Summary

  • Make sure the checks actually pass

Checklist

For Code changes

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • PR contains the label area:operator
  • Commits are signed off
  • Link this PR to related issues
  • I have not made any changes in the charts/ directory.

Some are rather nitpicky, others are more of the "how do I Go" category.

Signed-off-by: Manuel Hutter <[email protected]>
@mhutter mhutter requested a review from a team as a code owner October 9, 2024 16:26
@mhutter mhutter requested review from TheBigLee and zugao and removed request for a team October 9, 2024 16:26
Copy link
Collaborator

@zugao zugao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TheBigLee TheBigLee added the bug Something isn't working label Oct 10, 2024
@TheBigLee TheBigLee merged commit 77c54f2 into k8up-io:master Oct 10, 2024
5 checks passed
@mhutter mhutter deleted the cleanup branch October 14, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants