Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move reaper's skipSchemaMigration to ReaperTemplate #1448

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

a-mroz
Copy link
Contributor

@a-mroz a-mroz commented Nov 18, 2024

This way it should be available in both Reaper.spec and K8ssandraCluster.spec.reaper

What this PR does:

Which issue(s) this PR fixes:
Fixes #1667

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CHANGELOG.md updated (not required for documentation PRs)
  • CLA Signed: DataStax CLA

This way it should be available in both Reaper.spec and
K8ssandraCluster.spec.reaper
@a-mroz a-mroz requested a review from a team as a code owner November 18, 2024 13:11
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.12%. Comparing base (42de723) to head (8ac8b1c).
Report is 17 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1448      +/-   ##
==========================================
+ Coverage   59.02%   59.12%   +0.10%     
==========================================
  Files         125      125              
  Lines       12695    12708      +13     
==========================================
+ Hits         7493     7514      +21     
+ Misses       4524     4520       -4     
+ Partials      678      674       -4     
Files with missing lines Coverage Δ
apis/reaper/v1alpha1/reaper_types.go 94.73% <ø> (ø)

... and 6 files with indirect coverage changes

---- 🚨 Try these New Features:

Copy link
Contributor

@adejanovski adejanovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and makes total sense to expose the field in the K8ssandraCluster spec.
Thanks for creating this PR!

@adejanovski adejanovski merged commit fa2154b into k8ssandra:main Nov 20, 2024
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow passing environment variables to Reaper
2 participants